Source code
Revision control
Copy as Markdown
Other Tools
Test Info:
- Manifest: tools/tryselect/test/python.toml
from contextlib import ExitStack
from unittest.mock import MagicMock, patch
import mozunit
import pytest
from tryselect import push
@pytest.mark.parametrize(
"method,labels,params,routes,expected",
(
pytest.param(
"fuzzy",
["task-foo", "task-bar"],
None,
None,
{
"parameters": {
"optimize_target_tasks": False,
"try_task_config": {
"env": {"TRY_SELECTOR": "fuzzy"},
"tasks": ["task-bar", "task-foo"],
},
},
"version": 2,
},
id="basic",
),
pytest.param(
"fuzzy",
["task-foo"],
{"existing_tasks": {"task-foo": "123", "task-bar": "abc"}},
None,
{
"parameters": {
"existing_tasks": {"task-bar": "abc"},
"optimize_target_tasks": False,
"try_task_config": {
"env": {"TRY_SELECTOR": "fuzzy"},
"tasks": ["task-foo"],
},
},
"version": 2,
},
id="existing_tasks",
),
pytest.param(
"fuzzy",
["task-" + str(i) for i in range(1001)], # 1001 tasks, over threshold
None,
None,
{
"parameters": {
"optimize_target_tasks": False,
"try_task_config": {
"env": {"TRY_SELECTOR": "fuzzy"},
"priority": "lowest",
"tasks": sorted(["task-" + str(i) for i in range(1001)]),
},
},
"version": 2,
},
id="large_push_with_priority",
),
pytest.param(
"fuzzy",
["task-" + str(i) for i in range(500)], # 500 tasks with rebuild=3
{"try_task_config": {"rebuild": 3}},
None,
{
"parameters": {
"optimize_target_tasks": False,
"try_task_config": {
"env": {"TRY_SELECTOR": "fuzzy"},
"priority": "lowest",
"rebuild": 3,
"tasks": sorted(["task-" + str(i) for i in range(500)]),
},
},
"version": 2,
},
id="large_push_with_rebuild",
),
pytest.param(
"fuzzy",
["task-" + str(i) for i in range(100)], # Under threshold
None,
None,
{
"parameters": {
"optimize_target_tasks": False,
"try_task_config": {
"env": {"TRY_SELECTOR": "fuzzy"},
"tasks": sorted(["task-" + str(i) for i in range(100)]),
},
},
"version": 2,
},
id="small_push_no_priority",
),
pytest.param(
"fuzzy",
[
"task-" + str(i) for i in range(1001)
], # Large push with existing priority
{"try_task_config": {"priority": "low"}},
None,
{
"parameters": {
"optimize_target_tasks": False,
"try_task_config": {
"env": {"TRY_SELECTOR": "fuzzy"},
"priority": "low", # Should keep existing priority
"tasks": sorted(["task-" + str(i) for i in range(1001)]),
},
},
"version": 2,
},
id="large_push_existing_priority",
),
),
)
def test_generate_try_task_config(method, labels, params, routes, expected):
# Simulate user responding "yes" to the large push prompt
with patch("builtins.input", return_value="y"):
assert (
push.generate_try_task_config(method, labels, params=params, routes=routes)
== expected
)
def test_large_push_user_declines():
"""Test that when user declines large push warning, the system exits."""
with patch("builtins.input", return_value="n"):
with pytest.raises(SystemExit) as exc_info:
push.generate_try_task_config(
"fuzzy",
["task-" + str(i) for i in range(1001)],
)
assert exc_info.value.code == 1
def test_large_push_warning_message(capsys):
"""Test that the warning message is displayed for large pushes."""
with patch("builtins.input", return_value="y"):
push.generate_try_task_config(
"fuzzy",
["task-" + str(i) for i in range(1001)],
)
captured = capsys.readouterr()
assert "Your push would schedule at least 1001 tasks" in captured.out
assert "lower priority" in captured.out
def test_get_sys_argv():
input_argv = [
"./mach",
"try",
"fuzzy",
"--full",
"--artifact",
"--push-to-vcs",
"--query",
"'android-hw !shippable !nofis",
"--no-push",
]
expected_string = './mach try fuzzy --full --artifact --push-to-vcs --query "\'android-hw !shippable !nofis" --no-push'
assert push.get_sys_argv(input_argv) == expected_string
def test_get_sys_argv_2():
input_argv = [
"./mach",
"try",
"fuzzy",
"--query",
"'test-linux1804-64-qr/opt-mochitest-plain-",
"--worker-override=t-linux-large=gecko-t/t-linux-2204-wayland-experimental",
"--no-push",
]
expected_string = './mach try fuzzy --query "\'test-linux1804-64-qr/opt-mochitest-plain-" --worker-override=t-linux-large=gecko-t/t-linux-2204-wayland-experimental --no-push'
assert push.get_sys_argv(input_argv) == expected_string
@pytest.mark.parametrize(
"url,push_to_vcs,expect_direct_push",
[
pytest.param(
False,
True,
id="non_hg_remote_https",
),
pytest.param(
"git@github.com:mozilla/fake-try.git",
False,
True,
id="non_hg_remote_git",
),
pytest.param(
False,
True,
id="non_hg_remote_partial_match",
),
pytest.param(
False,
False,
id="hg_remote_uses_lando",
),
pytest.param(
True,
True,
id="push_to_vcs",
),
],
)
def test_push_to_try_routing(
mock_push_to_lando_try,
url,
push_to_vcs,
expect_direct_push,
):
mock_vcs = MagicMock()
mock_vcs.get_remote_url.return_value = url
mock_vcs.branch = "feature-branch"
mock_metrics = MagicMock()
mock_metrics.mach_try.commit_prep.start = MagicMock()
mock_metrics.mach_try.commit_prep.stop = MagicMock()
with ExitStack() as stack:
stack.enter_context(patch("tryselect.push.vcs", mock_vcs))
stack.enter_context(patch("tryselect.push.MACH_TRY_REMOTE", url))
mock_lando = stack.enter_context(mock_push_to_lando_try)
stack.enter_context(patch("tryselect.push.check_working_directory"))
stack.enter_context(
patch(
"tryselect.push.generate_try_task_config",
return_value={"tasks": ["task1"]},
)
)
push._is_hg_try.cache_clear()
is_hg_try = "ssh://hg.mozilla.org/try" in url
if push_to_vcs or not is_hg_try:
mock_vcs.try_commit.return_value.__enter__ = MagicMock(
return_value="abc123"
)
mock_vcs.try_commit.return_value.__exit__ = MagicMock(return_value=False)
push.push_to_try(
"fuzzy",
"try: test",
mock_metrics,
push_to_vcs=push_to_vcs,
dry_run=False,
)
if expect_direct_push:
mock_lando.assert_not_called()
if is_hg_try:
# For hg remotes, push_to_try is called
mock_vcs.push_to_try.assert_called_once()
else:
# For non-hg remotes, try_commit and push are called
mock_vcs.try_commit.assert_called_once()
mock_vcs.push.assert_called_once_with(
url,
ref="abc123",
dest_branch="feature-branch",
force=True,
)
else:
mock_lando.assert_called_once()
mock_vcs.push_to_try.assert_not_called()
if __name__ == "__main__":
mozunit.main()